Problem with wordpress folder search code

This is regarding a bug that was causing errors in our installation of s2member using wordpress plugins path re-assignment. The following code in the s2member plugin s2member/includes/classes/utils-s2o.inc.php wp_dir function has a problem in that it does not search all directories in the hierarchy because it reassigns $dir on each iteration but then tries to traverse from that point…focus on the code in the $one_dir_up loop and it’s effect on the outer loops…

foreach (array ($starting_dir, $alt_starting_dir) as $directory)
if ($directory && is_string ($directory) && is_dir ($directory))
for ($i = 0, $dir = $directory; $i <= 20; $i++)
{
for ($one_dir_up = 0; $one_dir_up < $i; $one_dir_up++)
$dir = dirname ($dir);
if (file_exists ($dir . "/wp-settings.php"))
return ($wp_dir = $dir);
}

Also this unnecessarily starts the search in the s2member folder itself… Sample fixed implementation that successfully searches all folders is as follows:

foreach (array ($starting_dir, $alt_starting_dir) as $directory)
if ($directory && is_string ($directory) && is_dir ($directory))
for ($i = 0, $dir = $directory, $dir2=''; $i <= 20; $i++)
{
$dir = dirname ($dir);
if ($dir2 == $dir) break;
$dir2 = $dir;
if (file_exists ($dir . "/wp-settings.php"))
return ($wp_dir = $dir);
}

Thank you for looking into correcting this…

Thanks, Robert. I’ll forward it to Jason for review. :)

Thank you!

I’m having this fixed in development. This will get pushed out in the next maintenance release.