Code Problems

I made the following changes to s2Member to avoid problems. You may want to do the same.

• wp-content/plugins/s2member/includes/classes/admin-notices.inc.php [Notice Message]
o Change line 136 to
if (!$page || “*” === $page || $pagenow === $page || (isset($_GET[“page”]) && $_GET[“page”] === $page))
• wp-content/plugins/s2member/includes/classes /users-list-in.inc.php [Notice Message]
o Change line 468 to
if(!empty($fields) && array_key_exists($field_var, $fields)){
unset ($fields[$field_var]);
}
• wp-content/plugins/s2member/includes/classes /profile-mods-in.inc.php [Notice Message]
o Change line 108 to
if(!empty($fields) && array_key_exists($field_var, $fields)){
unset ($fields[$field_var]);
}

Steve,

Could you please past an uncorrupted version of your code, and put it inside the code tags? Thanks!

– Eduan

Eduan,

How’s this? BTW, Notice Messages appear when WP_DEBUG is true.

Steve

wp-content/plugins/s2member/includes/classes/admin-notices.inc.php [Notice Message]
Change line 136 to

if (!$page || "*" === $page || $pagenow === $page || (isset($_GET["page"]) && $_GET["page"] === $page))

wp-content/plugins/s2member/includes/classes /users-list-in.inc.php [Notice Message]
Change line 468 to

if(!empty($fields) && array_key_exists($field_var, $fields)){
  unset ($fields[$field_var]);
}

wp-content/plugins/s2member/includes/classes /profile-mods-in.inc.php [Notice Message]
Change line 108 to

if(!empty($fields) && array_key_exists($field_var, $fields)){
  unset ($fields[$field_var]);
}

That’s better. :)

Although honestly, I’m personally not able to provide much help. :P
I just said it so that if somebody can help then they can read the code clearly. :)

– Eduan

Eduan,

I wasn’t requesting help. I just wanted the s2Member developers to be aware of 3 potential problems and what I did to correct them.

Steve

Ah I see, oops!

I’ll notify Jason of this. :)

Exactly what did you fix however? It isn’t too clear.

– Eduan

Here’s what he said, quote:

It looks like he’s trying to get rid of PHP debugging NOTICES in PHP, because he’s running WordPress in WP_DEBUG mode. The changes he’s suggesting are pretty good ones. However, they’re not necessary. That is, they don’t fix anything, they just cleanup the code and prevent notices from occurring, making the code more solid overall.

s2X will be compatible with WP_DEBUG mode. However, I’m not planning to update the existing software to support this, simply because it would leave too much room for error, and perhaps introduce bugs into an otherwise stable application :-)