s2member shows notice for undef. variable+fix

I’ve been working on a new plugin with debug turned on. Here is what I found.

( ! ) Notice: Undefined variable: cache_needs_updating in C:xxxxxxxxhtdocswp-contentpluginss2memberincludesclassescache.inc.php on line 97

old:
if ($cache_needs_updating) /* Cache is also reset dynamically during back-end option updates. */
{
update_option (“ws_plugin__s2member_cache”, $GLOBALS[“WS_PLUGIN__”][“s2member”][“c”][“cache”]);
}

fix:
if (!empty($cache_needs_updating)) /* Cache is also reset dynamically during back-end option updates. */
{
update_option (“ws_plugin__s2member_cache”, $GLOBALS[“WS_PLUGIN__”][“s2member”][“c”][“cache”]);
}

I just updated to the latest version: 130207

( ! ) Notice: Use of undefined constant NC_Markdown_Parser – assumed ‘NC_Markdown_Parser’ in C:projectsclientsxxxxxhtdocswp-contentpluginss2memberincludesexternalsmarkdownnc-markdown.inc.php on line 30

Just put NC_Markdown_Parser in quotes.
$parser_class = ‘NC_Markdown_Parser’;

The notices still show up.

Only two extremely simple fixes. Please let Jason know. It’ll take just 30 seconds to fix.

1) htdocs\wp-content\plugins\s2member\includes\classes\cache.inc.php
#line 94
replace this line
if /* Cache is also reset dynamically during back-end option updates. */ ($cache_needs_updating)

with
if /* Cache is also reset dynamically during back-end option updates. */ (!empty($cache_needs_updating))

2) Notice: Undefined index: page in htdocs\wp-content\plugins\s2member\includes\classes\admin-notices.inc.php on line 134

if (!$page || “*” === $page || $pagenow === $page || $_GET[“page”] === $page)

with

if (empty($page) || “*” === $page || $pagenow === $page || (!empty($_GET[“page”]) && $_GET[“page”] === $page) )