s2member/includes/classes/cache.inc.php

A Not so urgent fix to your code.

The Variable $cache_needs_updating is not defined.

Setting $cache_needs_updating = false;

public static function cached_page_links ()
{
  $cache_needs_updating = false; // Give it a known value instead of letting it flap in the breeze!
  do_action ("ws_plugin__s2member_before_cached_page_links", get_defined_vars ());

It’s required when the code hits…

if /* Cache is also reset dynamically during back-end option updates. */ ($cache_needs_updating)
{
update_option ("ws_plugin__s2member_cache", $GLOBALS["WS_PLUGIN__"]["s2member"]["c"]["cache"]);

and not having it defined is naughty ( as you know)!

I know WP is fully plagued by this – having error reporting set to full whinge mode floods your screen.
I had WP debug mode set and this came up.

Cheers
Tim

Thanks for the report Tim! I’ll report it to Jason. :)

Hello Tim,

Thanks for reporting this and providing a solution. He says that you can get rid of this error by simply disabling WP debug mode.

This is not going to be fixed in the maintenance versions, however the next major version of s2Member will fix all of these errors.

– Eduan