latest stable versions: v150827 (changelog)

Old Forums (READ-ONLY): The community now lives at WP Sharks™. If you have an s2Member® Pro question, please use our new Support System.

Home Forums TJ

TJ


My Latest Replies (From Various Topics)

Viewing 11 replies - 51 through 61 (of 61 total)
Author Replies
Author Replies
Posted: Wednesday Nov 21st, 2012 at 2:06 am #32205
TJ
Username: wellwater

Thanks Cristián. I sent it.

Posted: Tuesday Nov 20th, 2012 at 1:08 pm #32116
TJ
Username: wellwater

Hi Cristián,

I meant can I send you the email directly at your yourname [at] s2member [dot] com address rather than filling out the form above?

Thanks.

Posted: Tuesday Nov 20th, 2012 at 1:18 am #32055
TJ
Username: wellwater

Hi Cristián,

Sorry to be a bother, but can I directly email you the logs as a .zip file?

Thanks.

Posted: Sunday Nov 18th, 2012 at 12:38 pm #31936
TJ
Username: wellwater

Hi Cristián,

Can I email you the logs directly instead of uploading it using the form? Can it be diagnosed with just the logs as a first step?

Thanks.

Posted: Thursday Nov 1st, 2012 at 11:11 pm #30387
TJ
Username: wellwater

Hi Anton,

Sure. Your drop-downs show January and 2012 by default. What if someone submits the form without changing those values? This would prevent your “on change” event from ever firing and populating the hidden input text field with “01/2012”. You’ll either have to 1) pre-populate the hidden input text with something such as “01/2012”, 2) insert the value on form submission (while not colliding with s2member’s own javascript validation script), or 3) put blank options at the top which would signal to the user that something needs to be chosen. But if you took the third approach you risk s2member’s javascript validation saying that “mm/yyyy” needs filling out, which could confuse the user.

s2member has its own javascript validation that fires on form submission, but it also performs server-side validation, such as a during a failed transaction. After a server-side validation error occurs, the form is reloaded with the fields pre-populated with what the user already filled in. The expiration date is one of those fields. So you’ll have to grab what’s in the hidden text input field and set your drop-downs to match it.

This is all alot of work and prone to risk, which is why I think it would be safest for this functionality to be in s2member’s core.

Posted: Tuesday Oct 30th, 2012 at 10:44 pm #30231
TJ
Username: wellwater

Thanks as well, Anton, for the code.

It looks like it would have to be updated with code that checks the hidden expiration date value for an existing value, such as when the form reloads, then select those values in the dropdowns. I’m also concerned about any validation collisions that can occur, such as s2member attempting to validate, server-side, if the expiration date is expired or not (ie, Jan-2012).

Finally, the hidden input would have to at least be pre-populated with an initial month and year combo or else the native s2member javascript validation will say that’s it’s empty on submit, even though the select boxes would have a month and year selected by default.

I certainly think the code is workable, but I’m a little hesitant to use it in a production environment as-is.

  • This reply was modified 4 years, 2 months ago by  TJ.
  • This reply was modified 4 years, 2 months ago by  TJ.
Posted: Monday Oct 29th, 2012 at 3:18 am #29997
TJ
Username: wellwater

Hi Cristián. Thanks. I believe having a drop down instead of the text field for the expiration date would be a great addition/feature change. I believe it could have a positive impact on potential cart/order abandonment from the more casual impulse buyers. Expiration date drop-downs are pretty standardized and having it as a text field seems to be a significant deviation from the norm.

Posted: Thursday Oct 11th, 2012 at 3:59 pm #28161
TJ
Username: wellwater

Hi Cristián. Thanks for the suggestion. That looks like a good way to go.

Posted: Thursday Oct 4th, 2012 at 8:25 pm #27513
TJ
Username: wellwater

Hi Raam,

Thanks. I think that will work.

Posted: Saturday Jul 28th, 2012 at 11:29 pm #20580
TJ
Username: wellwater

Thanks for the assist Cristián & Jason.

Posted: Saturday Jul 28th, 2012 at 8:43 pm #20574
TJ
Username: wellwater

Hi,

Thanks for the replies Jason and Cristián. If I copy the authnet-responses.inc.php class to /wp-content/mu-plugins/ and s2member later upgrades authnet-responses.inc.php, couldn’t that lead to some sort of future breakage down the line?

Is it possible to do this in a hook so the override I’m applying is as slight and small as possible?

Thanks.

Viewing 11 replies - 51 through 61 (of 61 total)

Old Forums (READ-ONLY): The community now lives at WP Sharks™. If you have an s2Member® Pro question, please use our new Support System.

Contacting s2Member: Please use our Support Center for bug reports, pre-sale questions & technical assistance.