BuddyPress Redirecting From Login Welome Page

I’ve watched the video at http://www.s2member.com/videos/73410BDAD0526234/ titled “Login Welcome Page Conflicts”. The video says that the problem with BuddyPress causing a redirect back to the home page has been resolved. However, I’m having that issue if a user clicks the Login link in the BuddyPress toolbar.

I’m running a WordPress multisite installation with the latest versions of WordPress, BuddyPress, bbPress, and S2 Member Pro. I also used iThemes Builder to create the WordPress theme.

I followed the suggestion in the video to use Firebug and yep it confirmed the redirect on the Submit button on ONLY the login forms when you click the Login link on the BuddyPress toolbar.

Looking at wp-login.php I found the following code starting at line #672:

<form name="loginform" id="loginform" action="<?php echo esc_url( site_url( 'wp-login.php', 'login_post' ) ); ?>" method="post">
	<p>
		<label for="user_login"><?php _e('Username') ?><br />
		<input type="text" name="log" id="user_login" class="input" value="<?php echo esc_attr($user_login); ?>" size="20" tabindex="10" /></label>
	</p>
	<p>
		<label for="user_pass"><?php _e('Password') ?><br />
		<input type="password" name="pwd" id="user_pass" class="input" value="" size="20" tabindex="20" /></label>
	</p>
<?php do_action('login_form'); ?>
	<p class="forgetmenot"><label for="rememberme"><input name="rememberme" type="checkbox" id="rememberme" value="forever" tabindex="90"<?php checked( $rememberme ); ?> /> <?php esc_attr_e('Remember Me'); ?></label></p>
	<p class="submit">
		<input type="submit" name="wp-submit" id="wp-submit" class="button-primary" value="<?php esc_attr_e('Log In'); ?>" tabindex="100" />
<?php	if ( $interim_login ) { ?>
		<input type="hidden" name="interim-login" value="1" />
<?php	} else { ?>
        <!-- BAW 07/22/2012 - Disabled to prevent BuddyPress from redirecting back to home page -->
	<!-- <input type="hidden" name="redirect_to" value="<?php echo esc_attr($redirect_to); ?>" />  -->
<?php 	}  ?>
<?php   if ( $customize_login ) : ?>
		<input type="hidden" name="customize-login" value="1" />
<?php   endif; ?>
		<input type="hidden" name="testcookie" value="1" />
	</p>
</form>

Note that I commented out line #688 which was allowing BuddyPress to do the redirect. With no redirect being done, S2 Member Pro can now handle redirection to the specified Login Welcome Page.

This seems to have fixed the problem temporarily. Of course, I imagine that I’ll have to keep making this change every time I upgrade WordPress so it’s not what I’d consider optimal.

Do you have any suggestions as to a better way to get around this issue?

Thank you in advance.

Bruce,

Hi Bruce,

Thank you for the thorough explanation and for sharing your fix. I will send Jason, the lead developer, a message to see if he can shed any additional insight here when he gets a chance.

Thanks for the heads up on this request for support.

What you’re referring to is related to code found in BuddyPress, in file: bp-core-buddybar.php

function bp_adminbar_login_menu() {
	global $bp;

	if ( is_user_logged_in() )
		return false;

	echo '<li class="bp-login no-arrow"><a href="' . bp_get_root_domain() . '/wp-login.php?redirect_to=' . urlencode( bp_get_root_domain() ) . '">' . __( 'Log In', 'buddypress' ) . '</a></li>';

	// Show "Sign Up" link if user registrations are allowed
	if ( bp_get_signup_allowed() )
		echo '<li class="bp-signup no-arrow"><a href="' . bp_get_signup_page(false) . '">' . __( 'Sign Up', 'buddypress' ) . '</a></li>';
}

Unfortunately, there’s no filter provided by BuddyPress for this. So what you’ve already done, is fine. Other options might include editing the BuddyPress file instead of the WordPress core file. Or, instead of making any code changes, add some jQuery to your site, which automatically removes the redirect_to argument from URLs that contain wp-login.php.