Please fix cache.inc.php on line 97

We’re getting a Undefined variable: cache_needs_updating in cache.inc.php on line 97. Please initialize the variable with a default value at the top of the function block (probably cache_needs_updating = false) or define it as global (which it probably is not).

We’ve got lots of debugging of our own stuff to do and these unnecessary notices are interfering with header transmissions, etc. Please fix in next release please.

Hello Stephen,

I suppose that is for Quick Cache correct?

No, cache.inc.php is in the s2Member plugin folder under “includes”, “classes”

OK Stephen, got it.

Just to get this out of the way, have you made a theme compatibility test? Just change the theme back to the default TwentyEleven theme.

Please also do a plugin compatibility test, just disable all the plugins and see if the problem still remains, if it doesn’t it means that a plugin is not compatible with s2Member, to find out which you ccan enable the plugins one-by-one until the problem appears again.

Hope this helps. :)

Hello Eduan,
This problem occurs on a new installation with no other plugins. Here are the steps to re-produce the problem:

1) Install WordPress 3.4.1
2) Install s2Member plugin
3) Set WP_DEBUG to true in wp-config.php

Please fix the problem by appending:

cache_needs_updating = false;

to line 45 of cache.inc.php

Also, another warning is thrown “Undefined index” in admin-notices.inc.php.

Please fix the problem by appending:

$_GET["page"] = isset( $_GET["page"] ) ? $_GET["page"] : '';

to line 135 of admin-notices.inc.php.

Again, these problems will not affect most users that do not have WP_DEBUG set to true, as they are just warnings. But this problem will affect users doing website development that have debugging turned on. A properly coded plugin should not throw these warnings as it makes website development difficult and can invoke ‘header already sent’ errors -real errors that inhibit development. Likewise, these warnings indicate are true: variable parameters should be checked and initialized accordingly.

Lastly, I’ve submitted the fix for you above. Please simply incorporate these changes so I don’t have to each time the plugin is updated.

Thank you!

Hi Stephen,

Thank you for the information! I have forwarded this thread to Jason (the lead developer), so he can take a look at this.

Awarded Stephen Carroll the Helpful badge.